There were (at least) three cases where thumbnails would not display, if they were generated while the FileSystemDock was not visible:
- current_path == "Favorites", due to p_path not starting with "Favorites"
- current_path == "res://", due to current_path having last "/" trimmed for comparison
- current_path pointing to a selected file instead of folder, since it no longer matches p_path's base directory
This change removes the current_path and is_visible_in_tree checks when determining whether to update the file's icon.
Fixes#90801Fixes#91432
When renaming or moving global scripts, the following errors can appear:
- Attempt to open script 'xxx' resulted in error 'File not found'.
- Failed loading resource: xxx. Make sure resources have been imported by opening the project in the editor at least once.
- Parser Error: Class 'xxx' hides a global script class.
When deleting scripts, errors appear when opening the 'Create Node Dialog' as the script cache still contains the removed global scripts. The following errors can appear:
- Attempt to open script 'xxx' resulted in error 'File not found'.
- Failed loading resource: xxx. Make sure resources have been imported by opening the project in the editor at least once.
editor/create_dialog.cpp:241 - Condition "scr.is_null()" is true.
All this errors can be fixed by correctly handling the cases. They involves removing the old path and adding the new one (if not deleted) to the ScriptServer. This is somewhat similar if the file is moved or deleted outside Godot and detected by the file watcher, but more specialized for this particular usecase, since we know the old and the new path / correctly know what the user just did.
This also tweaks EditorFileDialog to use the same shortcut,
while making it select the path text after focusing
(like in most file managers).
Ctrl + L / Cmd + Shift + G can also now be used to focus on the
property name in the project settings editor, as well in the
Input Map, Autoload, Shader Globals and Global Groups tabs.
The previous implementation of opening a terminal
in the FileSystem dock was causing errors due to the use
of a bash builtin command that does not work outside the shell.
This resulted in the following error messages:
ERROR: Could not create child process: command
at: execute (drivers/unix/os_unix.cpp:553)
ERROR: Could not create child process: command
at: execute (drivers/unix/os_unix.cpp:553)
...
To resolve this issue,
+ the command is now executed inside a bash shell,
+ if the `terminal_emulator_flags` editor option is empty,
the working directory for gnome-terminal and urxvt is now properly set.
