seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed CSG debug collision shapes being visible in editor. Also undid an old, incorrect fix which made debug collision visibility depend on CSG visibility.

Browse Source
This commit is contained in:
Zi Ye
2024-01-01 19:36:36 -06:00
parent 27552a2f26
commit a9e51c3aab
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/csg/csg_shape.cpp
View File

@ -513,7 +513,7 @@ Ref<ConcavePolygonShape3D> CSGShape3D::bake_collision_shape() {
} }
bool CSGShape3D::_is_debug_collision_shape_visible() { bool CSGShape3D::_is_debug_collision_shape_visible() {
return is_inside_tree() && (get_tree()->is_debugging_collisions_hint() || Engine::get_singleton()->is_editor_hint()); return !Engine::get_singleton()->is_editor_hint() && is_inside_tree() && get_tree()->is_debugging_collisions_hint();
} }
void CSGShape3D::_update_debug_collision_shape() { void CSGShape3D::_update_debug_collision_shape() {
@ -604,11 +604,6 @@ void CSGShape3D::_notification(int p_what) {
// Update this node's parent only if its own visibility has changed, not the visibility of parent nodes // Update this node's parent only if its own visibility has changed, not the visibility of parent nodes
parent_shape->_make_dirty(); parent_shape->_make_dirty();
} }
if (is_visible()) {
_update_debug_collision_shape();
} else {
_clear_debug_collision_shape();
}
last_visible = is_visible(); last_visible = is_visible();
} break; } break;