seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #95984 from timothyqiu/what-identifier

Browse Source 
Add `String.is_valid_unicode_identifier()`
This commit is contained in:
Rémi Verschelde
2024-08-27 16:55:06 +02:00
parent 3db976bdb7 8bf4ecc026
commit 9dfc41568a
22 changed files with 132 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/gdscript/gdscript_editor.cpp
View File

@ -97,8 +97,8 @@ Ref<Script> GDScriptLanguage::make_template(const String &p_template, const Stri
}
processed_template = processed_template.replace("_BASE_", p_base_class_name)
.replace("_CLASS_SNAKE_CASE_", p_class_name.to_snake_case().validate_identifier())
.replace("_CLASS_", p_class_name.to_pascal_case().validate_identifier())
.replace("_CLASS_SNAKE_CASE_", p_class_name.to_snake_case().validate_ascii_identifier())
.replace("_CLASS_", p_class_name.to_pascal_case().validate_ascii_identifier())
.replace("_TS_", _get_indentation());
scr->set_source_code(processed_template);
return scr;
@ -3486,7 +3486,7 @@ static void _find_call_arguments(GDScriptParser::CompletionContext &p_context, c
// is not a valid identifier.
bool path_needs_quote = false;
for (const String &part : opt.split("/")) {
if (!part.is_valid_identifier()) {
if (!part.is_valid_ascii_identifier()) {
path_needs_quote = true;
break;
}