seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #84445 from Rubonnek/add-const-references-clang-tidy

Browse Source 
Add const references detected by clang-tidy
This commit is contained in:
Rémi Verschelde
2024-01-04 14:25:33 +01:00
parent b66d16fcc9 a3cb1b096f
commit 6c390b620d
57 changed files with 119 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scene/gui/popup_menu.cpp
View File

@ -2546,7 +2546,7 @@ bool PopupMenu::_set(const StringName &p_name, const Variant &p_value) {
Vector<String> components = String(p_name).split("/", true, 2);
if (components.size() >= 2 && components[0].begins_with("item_") && components[0].trim_prefix("item_").is_valid_int()) {
int item_index = components[0].trim_prefix("item_").to_int();
String property = components[1];
const String &property = components[1];
if (property == "text") {
set_item_text(item_index, p_value);
return true;
@ -2625,7 +2625,7 @@ bool PopupMenu::_get(const StringName &p_name, Variant &r_ret) const {
Vector<String> components = String(p_name).split("/", true, 2);
if (components.size() >= 2 && components[0].begins_with("item_") && components[0].trim_prefix("item_").is_valid_int()) {
int item_index = components[0].trim_prefix("item_").to_int();
String property = components[1];
const String &property = components[1];
if (property == "text") {
r_ret = get_item_text(item_index);
return true;