seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Port member initialization from constructor to declaration (C++11)

Browse Source 
Using `clang-tidy`'s `modernize-use-default-member-init` check and
manual review of the changes, and some extra manual changes that
`clang-tidy` failed to do.

Also went manually through all of `core` to find occurrences that
`clang-tidy` couldn't handle, especially all initializations done
in a constructor without using initializer lists.
This commit is contained in:
Rémi Verschelde
2020-05-12 17:01:17 +02:00
parent e7c9d81876
commit 1f6f364a56
325 changed files with 1689 additions and 3480 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/xaudio2/audio_driver_xaudio2.cpp
View File

@ -196,15 +196,9 @@ void AudioDriverXAudio2::finish() {
thread = nullptr;
}
AudioDriverXAudio2::AudioDriverXAudio2() :
thread(nullptr),
current_buffer(0) {
wave_format = { 0 };
AudioDriverXAudio2::AudioDriverXAudio2() {
for (int i = 0; i < AUDIO_BUFFERS; i++) {
xaudio_buffer[i] = { 0 };
samples_out[i] = 0;
}
}
AudioDriverXAudio2::~AudioDriverXAudio2() {
}

8
drivers/xaudio2/audio_driver_xaudio2.h
View File

@ -64,7 +64,7 @@ class AudioDriverXAudio2 : public AudioDriver {
void STDMETHODCALLTYPE OnVoiceError(void *pBufferContext, HRESULT Error) {}
};
Thread *thread;
Thread *thread = nullptr;
Mutex mutex;
int32_t *samples_in;
@ -83,9 +83,9 @@ class AudioDriverXAudio2 : public AudioDriver {
mutable bool exit_thread;
bool pcm_open;
WAVEFORMATEX wave_format;
WAVEFORMATEX wave_format = { 0 };
Microsoft::WRL::ComPtr<IXAudio2> xaudio;
int current_buffer;
int current_buffer = 0;
IXAudio2MasteringVoice *mastering_voice;
XAUDIO2_BUFFER xaudio_buffer[AUDIO_BUFFERS];
IXAudio2SourceVoice *source_voice;
@ -104,7 +104,7 @@ public:
virtual void finish();
AudioDriverXAudio2();
~AudioDriverXAudio2();
~AudioDriverXAudio2() {}
};
#endif