seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix leak when using audio samples instead of streams

Browse Source 
(cherry picked from commit d3ddce6b88)
This commit is contained in:
Adam Scott
2024-09-04 12:04:27 -04:00
committed by Rémi Verschelde
parent f11f9e3b7f
commit 0b815cbb99
8 changed files with 59 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/minimp3/audio_stream_mp3.cpp
View File

@ -159,6 +159,9 @@ Ref<AudioSamplePlayback> AudioStreamPlaybackMP3::get_sample_playback() const {
void AudioStreamPlaybackMP3::set_sample_playback(const Ref<AudioSamplePlayback> &p_playback) {
sample_playback = p_playback;
if (sample_playback.is_valid()) {
sample_playback->stream_playback = Ref<AudioStreamPlayback>(this);
}
}
void AudioStreamPlaybackMP3::set_parameter(const StringName &p_name, const Variant &p_value) {

3
modules/vorbis/audio_stream_ogg_vorbis.cpp
View File

@ -390,6 +390,9 @@ Ref<AudioSamplePlayback> AudioStreamPlaybackOggVorbis::get_sample_playback() con
void AudioStreamPlaybackOggVorbis::set_sample_playback(const Ref<AudioSamplePlayback> &p_playback) {
sample_playback = p_playback;
if (sample_playback.is_valid()) {
sample_playback->stream_playback = Ref<AudioStreamPlayback>(this);
}
}
AudioStreamPlaybackOggVorbis::~AudioStreamPlaybackOggVorbis() {